Bug 17067

Summary: eliminate attributes parameter from JSObject::put for speed/clarity
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ggaren, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 17094    
Bug Blocks:    
Attachments:
Description Flags
work in progress
none
patch (passes all regression tests, but ignores attributes in put call in C API)
none
patch andersca: review+

Darin Adler
Reported 2008-01-29 10:15:30 PST
I realized that JSObject::put doesn't really need an attributes parameter, so I'm working to get rid of it.
Attachments
work in progress (77.44 KB, patch)
2008-01-29 10:19 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (passes all regression tests, but ignores attributes in put call in C API) (68.09 KB, patch)
2008-02-08 01:50 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (83.56 KB, patch)
2008-02-23 12:59 PST, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-01-29 10:19:03 PST
Created attachment 18764 [details] work in progress
Darin Adler
Comment 2 2008-02-08 01:50:26 PST
Created attachment 19001 [details] patch (passes all regression tests, but ignores attributes in put call in C API)
Darin Adler
Comment 3 2008-02-09 07:21:15 PST
This is *so* close to being ready to review. The remaining issue is what we should do about the C API. Do we want to give the public put call the ability to assign attributes, and if so, how should we do this while preserving the rest of the semantics? Maybe it should do some combination of getDirect, putDirect, and put?
Darin Adler
Comment 4 2008-02-16 07:16:30 PST
Geoff, I'd like to land this. What do you think we should do about the attribute argument to JSObjectSetProperty? I think we discussed it but I forgot what we decided.
Darin Adler
Comment 5 2008-02-23 12:59:44 PST
Created attachment 19307 [details] patch
Anders Carlsson
Comment 6 2008-02-23 17:02:35 PST
Comment on attachment 19307 [details] patch r=me with the change we discussed on IRC
Darin Adler
Comment 7 2008-02-23 21:01:49 PST
Committed revision 30534.
Note You need to log in before you can comment on or make changes to this bug.