Summary: | WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, lforschler, simon.fraser, thorton | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-04-09 01:46:03 PDT
Created attachment 306611 [details]
Patch
Comment on attachment 306611 [details] Patch Attachment 306611 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3505055 Number of test failures exceeded the failure limit. Created attachment 306615 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
hmm, it seems the iOS changes are not correct, I'll try to figure out Created attachment 306668 [details]
Patch for landing
I think the problem in iOS is that we were releasing CARenderServerBufferRef too early, so I've added a callback to CGDataProviderCreateWithData and moved the call to CARenderServerDestroyBuffer there.
Created attachment 306672 [details]
Patch for landing
Comment on attachment 306672 [details] Patch for landing Clearing flags on attachment: 306672 Committed r215176: <http://trac.webkit.org/changeset/215176> All reviewed patches have been landed. Closing bug. |