Bug 170646

Summary:

Remove use of strcpy from JSC

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, jfbastien, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mark.lam: review+

Description Oliver Hunt 2017-04-08 15:20:41 PDT

Remove use of strcpy from JSC

Comment 1 Oliver Hunt 2017-04-08 15:22:33 PDT

Created attachment 306583 [details]
Patch

Comment 2 Oliver Hunt 2017-04-08 15:23:16 PDT

Unbelievably trivial patch :)

Comment 3 Mark Lam 2017-04-08 15:29:04 PDT

Comment on attachment 306583 [details]
Patch

r=me, but can you fix the GTK build failure?  Is strlcpy available for all posix?

Comment 4 Oliver Hunt 2017-04-08 19:13:07 PDT

Created attachment 306593 [details]
Patch

Comment 5 Mark Lam 2017-04-08 19:25:58 PDT

Comment on attachment 306593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306593&action=review

r=me with ChangeLog comment fixed.

> Source/JavaScriptCore/ChangeLog:10
> +        Replace the use of strcpy with strlcpy as strcpy keeps
> +        on tripping various analyser warnings even though its
> +        trivially safe in this case.

Your comment needs to be updated.

Comment 6 Oliver Hunt 2017-04-09 16:47:22 PDT

Committed r215168: <http://trac.webkit.org/changeset/215168>