Bug 170646

Summary: Remove use of strcpy from JSC
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Oliver Hunt
Reported 2017-04-08 15:20:41 PDT
Remove use of strcpy from JSC
Attachments
Patch (1.95 KB, patch)
2017-04-08 15:22 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2017-04-08 19:13 PDT, Oliver Hunt 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2017-04-08 15:22:33 PDT
Created attachment 306583 [details] Patch
Oliver Hunt
Comment 2 2017-04-08 15:23:16 PDT
Unbelievably trivial patch :)
Mark Lam
Comment 3 2017-04-08 15:29:04 PDT
Comment on attachment 306583 [details] Patch r=me, but can you fix the GTK build failure? Is strlcpy available for all posix?
Oliver Hunt
Comment 4 2017-04-08 19:13:07 PDT
Created attachment 306593 [details] Patch
Mark Lam
Comment 5 2017-04-08 19:25:58 PDT
Comment on attachment 306593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306593&action=review r=me with ChangeLog comment fixed. > Source/JavaScriptCore/ChangeLog:10 > + Replace the use of strcpy with strlcpy as strcpy keeps > + on tripping various analyser warnings even though its > + trivially safe in this case. Your comment needs to be updated.
Oliver Hunt
Comment 6 2017-04-09 16:47:22 PDT
Committed r215168: <http://trac.webkit.org/changeset/215168>
Note You need to log in before you can comment on or make changes to this bug.