Bug 170631

Summary: Web Inspector: navigation sidebar says "No Search Results" when a slow search is in progress
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Blaze Burg
Reported 2017-04-07 17:39:24 PDT
Steps to reproduce: 1. Remote debug a (slow/old) device 2. Go to the HTML5 spec-in-one-page 3. Search for something overbroad, like 'page' => Says "No Results" then flashes and shows results some time later when they start to arrive We should fix this so that we say "Searching [spinner]" while the backend does the search.
Attachments
Patch (12.46 KB, patch)
2019-02-12 15:48 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (12.36 KB, patch)
2019-02-25 23:51 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (14.61 KB, patch)
2019-02-25 23:59 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-04-07 17:40:08 PDT
<rdar://problem/29473874>
Devin Rousso
Comment 2 2019-02-12 15:48:46 PST
Created attachment 361856 [details] Patch
Joseph Pecoraro
Comment 3 2019-02-25 23:22:57 PST
Comment on attachment 361856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361856&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:272 > - DOMAgent.discardSearchResults(this._domSearchIdentifier); > + countPromise(DOMAgent.discardSearchResults(this._domSearchIdentifier)); We shouldn't need to wait on this one, it is just clearing old search data, not affecting the current search(es).
Devin Rousso
Comment 4 2019-02-25 23:51:05 PST
Created attachment 362967 [details] Patch
Devin Rousso
Comment 5 2019-02-25 23:59:11 PST
Created attachment 362968 [details] Patch
WebKit Commit Bot
Comment 6 2019-02-26 00:15:03 PST
Comment on attachment 362968 [details] Patch Clearing flags on attachment: 362968 Committed r242080: <https://trac.webkit.org/changeset/242080>
WebKit Commit Bot
Comment 7 2019-02-26 00:15:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.