Acid3 expects textNode.localName == null

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Acid3 expects textNode.localName == null

      // test 66: localName on attributes, from Sylvain Pasche
      var test = document.createTextNode("test");
      assertEquals(test.localName, null, 'wrong localName');
      return 5;

We return #text.  It would be interesting to know what other browsers do.

[Eric Seidel (no email)]

Created attachment 18757 [details]
test case

[Alexey Proskuryakov]

      // test 66: localName on attributes, from Sylvain Pasche
      var test = document.createTextNode("test");

What is the attribute the comment is talking about?

See also: bug 17048 (for createAttribute).

[Ian 'Hixie' Hickson]

the comment in the test was wrong. fixed.

[Eric Seidel (no email)]

Created attachment 18880 [details]
Fix textNode.localName and add tests to cover other node initial values

 LayoutTests/ChangeLog                              |   14 ++
 .../fast/dom/Node/initial-values-expected.txt      |  102 +++++++++++++++
 LayoutTests/fast/dom/Node/initial-values.html      |   13 ++
 LayoutTests/fast/dom/Node/resources/TEMPLATE.html  |   13 ++
 .../fast/dom/Node/resources/initial-values.js      |  138 ++++++++++++++++++++
 WebCore/ChangeLog                                  |   15 ++
 WebCore/dom/Comment.cpp                            |    5 -
 WebCore/dom/Comment.h                              |    1 -
 WebCore/dom/Node.cpp                               |    2 +-
 WebCore/dom/Text.cpp                               |    5 -
 WebCore/dom/Text.h                                 |    1 -
 11 files changed, 296 insertions(+), 13 deletions(-)

[Eric Seidel (no email)]

Created attachment 18881 [details]
Fix textNode.localName and add tests to cover other node initial values

 LayoutTests/ChangeLog                              |   14 ++
 .../fast/dom/Node/initial-values-expected.txt      |  130 ++++++++++++++
 LayoutTests/fast/dom/Node/initial-values.html      |   13 ++
 LayoutTests/fast/dom/Node/resources/TEMPLATE.html  |   13 ++
 .../fast/dom/Node/resources/initial-values.js      |  178 ++++++++++++++++++++
 WebCore/ChangeLog                                  |   15 ++
 WebCore/dom/Comment.cpp                            |    5 -
 WebCore/dom/Comment.h                              |    1 -
 WebCore/dom/Node.cpp                               |    2 +-
 WebCore/dom/Text.cpp                               |    5 -
 WebCore/dom/Text.h                                 |    1 -
 11 files changed, 364 insertions(+), 13 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 18880 [details]
Fix textNode.localName and add tests to cover other node initial values

I've updated this with a new patch which adds a couple more tests.

[Eric Seidel (no email)]

As previously mentioned, this test case tests for the exact behavior as spec'd in DOM Level 3.  There are a few failures remaining for WebKit.

Failures shared by FF3b2:
FAIL attr.localName should be null (of type object). Was foo (of type string).
FAIL attr.localName should be null (of type object). Was foo (of type string).
FAIL doc.namespaceURI should be http://www.w3.org/1999/xhtml (of type string). Was null (of type object).
FAIL element.localName should be null (of type object). Was pre (of type string).
(FF3b2 fails with "PRE" instead of "pre")
FAIL element.localName should be null (of type object). Was pre (of type string).
(FF3b2 fails with "pre" instead of "PRE" however.)

Failures unique to WebKit:
FAIL element.namespaceURI should be null (of type object). Was http://www.w3.org/1999/xhtml (of type string).
FAIL element.nodeName should be html:pre. Was PRE.
FAIL element.namespaceURI should be null (of type object). Was http://www.w3.org/1999/xhtml (of type string)

[Darin Adler]

Comment on attachment 18881 [details]
Fix textNode.localName and add tests to cover other node initial values

Seems OK, r=me.

[Eric Seidel (no email)]

I filed bug 17167 to track the "failures" in this test case.   Landed as r29953.  Yay for 73/100 on Acid3!

[Alexey Proskuryakov]

*** Bug 15949 has been marked as a duplicate of this bug. ***