Bug 170587

Summary: [JSC] Change --debug option to --debugger
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mattbaker, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
keith_miller: review+
Patch for landing
none
Patch for landing none

Caio Lima
Reported 2017-04-06 21:47:29 PDT
The new flag to trigger lldb on Tools/Scripts/run-jsc is shadowing the flag --debug to run JSC with Debug build. It should be good change it to --debugger.
Attachments
Patch (1.45 KB, patch)
2017-04-06 21:52 PDT, Caio Lima 		keith_miller: review+
DetailsFormatted DiffDiff
Patch for landing (1.77 KB, patch)
2017-04-07 04:00 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.77 KB, patch)
2017-04-07 11:06 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2017-04-06 21:52:09 PDT
Created attachment 306467 [details] Patch
Matt Baker
Comment 2 2017-04-06 22:03:18 PDT
Comment on attachment 306467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review > Tools/ChangeLog:10 > + This patch is chaging the new debugger flag for Tools/Scripts/run-jsc Typo: changing
Keith Miller
Comment 3 2017-04-06 22:04:58 PDT
Comment on attachment 306467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review r=me with comment. > Tools/Scripts/run-jsc:43 > my $debug = 0; nit: I would change this to $debugger.
Caio Lima
Comment 4 2017-04-07 04:00:04 PDT
Created attachment 306485 [details] Patch for landing Fixing Keith's comments
Caio Lima
Comment 5 2017-04-07 11:06:38 PDT
Created attachment 306517 [details] Patch for landing Fixing Typos as well.
Saam Barati
Comment 6 2017-04-07 11:46:38 PDT
Did you make sure "--debug" no longer launches a release build?
WebKit Commit Bot
Comment 7 2017-04-07 11:50:00 PDT
Comment on attachment 306517 [details] Patch for landing Clearing flags on attachment: 306517 Committed r215105: <http://trac.webkit.org/changeset/215105>
WebKit Commit Bot
Comment 8 2017-04-07 11:50:02 PDT
All reviewed patches have been landed. Closing bug.
Caio Lima
Comment 9 2017-04-07 16:26:12 PDT
(In reply to Saam Barati from comment #6) > Did you make sure "--debug" no longer launches a release build? Yes. I changed that because I always use "--debug" and "--release".
Note You need to log in before you can comment on or make changes to this bug.