Bug 170551

Summary: Web Inspector: RTL: layout issues in Open Resource Dialog
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, inspector-bugzilla-changes, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
ltr - before
none
RTL - before
none
RTL - after
none
Proposed Fix
mattbaker: review+
with flex:none none

Description BJ Burg 2017-04-06 10:23:03 PDT
Need to flip icons and padding.
Comment 1 BJ Burg 2017-04-06 10:23:24 PDT
Created attachment 306401 [details]
ltr - before
Comment 2 BJ Burg 2017-04-06 10:23:36 PDT
Created attachment 306402 [details]
RTL - before
Comment 3 BJ Burg 2017-04-06 10:26:16 PDT
Created attachment 306404 [details]
RTL - after
Comment 4 BJ Burg 2017-04-06 10:28:11 PDT
Created attachment 306405 [details]
Proposed Fix
Comment 5 Matt Baker 2017-04-06 10:39:30 PDT
(In reply to Brian Burg from comment #1)
> Created attachment 306401 [details]
> ltr - before

The vertical alignment of the icon feels off. It's possible some of the other recent RTL style changes affected "large" tree outlines, since its a more rare use case.
Comment 6 Matt Baker 2017-04-06 10:44:48 PDT
The list item item height is too small for the large-style tree outline. This patch it not to blame.
Comment 7 Matt Baker 2017-04-06 11:05:28 PDT
Setting `flex: none` on the tree items fixes the vertical size issue.
Comment 8 Matt Baker 2017-04-06 11:07:59 PDT
Comment on attachment 306405 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306405&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:159
>  .open-resource-dialog > .tree-outline .item {

Please confirm that adding `flex: none` here fixes the tree element sizing issue.
Comment 9 BJ Burg 2017-04-27 16:06:44 PDT
Created attachment 308469 [details]
with flex:none
Comment 10 BJ Burg 2017-04-27 16:09:21 PDT
Committed r215902: <http://trac.webkit.org/changeset/215902>