Bug 170551

Summary: Web Inspector: RTL: layout issues in Open Resource Dialog
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, inspector-bugzilla-changes, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
ltr - before
none
RTL - before
none
RTL - after
none
Proposed Fix
mattbaker: review+
with flex:none none

Blaze Burg
Reported 2017-04-06 10:23:03 PDT
Need to flip icons and padding.
Attachments
ltr - before (393.25 KB, image/png)
2017-04-06 10:23 PDT, Blaze Burg 		no flags
Details
RTL - before (270.82 KB, image/png)
2017-04-06 10:23 PDT, Blaze Burg 		no flags
Details
RTL - after (320.32 KB, image/png)
2017-04-06 10:26 PDT, Blaze Burg 		no flags
Details
Proposed Fix (5.68 KB, patch)
2017-04-06 10:28 PDT, Blaze Burg 		mattbaker: review+
DetailsFormatted DiffDiff
with flex:none (542.58 KB, image/png)
2017-04-27 16:06 PDT, Blaze Burg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-04-06 10:23:24 PDT
Created attachment 306401 [details] ltr - before
Blaze Burg
Comment 2 2017-04-06 10:23:36 PDT
Created attachment 306402 [details] RTL - before
Blaze Burg
Comment 3 2017-04-06 10:26:16 PDT
Created attachment 306404 [details] RTL - after
Blaze Burg
Comment 4 2017-04-06 10:28:11 PDT
Created attachment 306405 [details] Proposed Fix
Matt Baker
Comment 5 2017-04-06 10:39:30 PDT
(In reply to Brian Burg from comment #1) > Created attachment 306401 [details] > ltr - before The vertical alignment of the icon feels off. It's possible some of the other recent RTL style changes affected "large" tree outlines, since its a more rare use case.
Matt Baker
Comment 6 2017-04-06 10:44:48 PDT
The list item item height is too small for the large-style tree outline. This patch it not to blame.
Matt Baker
Comment 7 2017-04-06 11:05:28 PDT
Setting `flex: none` on the tree items fixes the vertical size issue.
Matt Baker
Comment 8 2017-04-06 11:07:59 PDT
Comment on attachment 306405 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306405&action=review r=me > Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:159 > .open-resource-dialog > .tree-outline .item { Please confirm that adding `flex: none` here fixes the tree element sizing issue.
Blaze Burg
Comment 9 2017-04-27 16:06:44 PDT
Created attachment 308469 [details] with flex:none
Blaze Burg
Comment 10 2017-04-27 16:09:21 PDT
Committed r215902: <http://trac.webkit.org/changeset/215902>
Note You need to log in before you can comment on or make changes to this bug.