Summary: | Web Inspector: RTL: layout issues in Open Resource Dialog | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bburg, inspector-bugzilla-changes, mattbaker | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
BJ Burg
2017-04-06 10:23:03 PDT
Created attachment 306401 [details]
ltr - before
Created attachment 306402 [details]
RTL - before
Created attachment 306404 [details]
RTL - after
Created attachment 306405 [details]
Proposed Fix
(In reply to Brian Burg from comment #1) > Created attachment 306401 [details] > ltr - before The vertical alignment of the icon feels off. It's possible some of the other recent RTL style changes affected "large" tree outlines, since its a more rare use case. The list item item height is too small for the large-style tree outline. This patch it not to blame. Setting `flex: none` on the tree items fixes the vertical size issue. Comment on attachment 306405 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306405&action=review r=me > Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:159 > .open-resource-dialog > .tree-outline .item { Please confirm that adding `flex: none` here fixes the tree element sizing issue. Created attachment 308469 [details]
with flex:none
Committed r215902: <http://trac.webkit.org/changeset/215902> |