Bug 170521

Summary: Refactor so WebsiteDataStores always have a StorageManager
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, commit-queue, ggaren, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170578    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-04-05 14:16:54 PDT
Refactor so WebsiteDataStores always have a StorageManager Even for ephemeral sessions.
Attachments
Patch (8.64 KB, patch)
2017-04-05 14:22 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.67 KB, patch)
2017-04-05 14:27 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-04-05 14:22:02 PDT
Created attachment 306314 [details] Patch
Geoffrey Garen
Comment 2 2017-04-05 14:25:10 PDT
Comment on attachment 306314 [details] Patch r=me
Brady Eidson
Comment 3 2017-04-05 14:27:57 PDT
Created attachment 306316 [details] Patch
WebKit Commit Bot
Comment 4 2017-04-05 15:38:27 PDT
Comment on attachment 306316 [details] Patch Clearing flags on attachment: 306316 Committed r214973: <http://trac.webkit.org/changeset/214973>
WebKit Commit Bot
Comment 5 2017-04-05 15:38:29 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2017-04-06 17:15:41 PDT
Re-opened since this is blocked by bug 170578
Brady Eidson
Comment 7 2017-04-07 09:02:53 PDT
There's significant UIProcess architecture issues that made this not be okay right now. Basically, a single WebProcess connection can have multiple data stores associated with it, meaning multiple StorageManagers, and we can't have more than one StorageManager registered for message handling on a given connection. I'll be resolving LocalStorage issues another way.
Note You need to log in before you can comment on or make changes to this bug.