Bug 170481

Summary: Add JF Bastien as reviewer 🎉
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Tools / TestsAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, glenn, jfbastien, lforschler, mark.lam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

JF Bastien
Reported 2017-04-04 15:38:28 PDT
🍾
Attachments
patch (1.39 KB, patch)
2017-04-04 15:40 PDT, JF Bastien 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-04-04 15:40:02 PDT
Created attachment 306221 [details] patch 🎉
Build Bot
Comment 2 2017-04-04 15:41:58 PDT
Attachment 306221 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2017-04-04 15:42:55 PDT
Comment on attachment 306221 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306221&action=review r=me with fixes. For future reference, you don't need a bug and a review for this change. A ChangeLog entry is needed though. > Tools/ChangeLog:3 > + Add JF Bastien as reviewer ð Can you remove the non-ascii char? > Tools/Scripts/webkitpy/common/config/contributors.json:-5831 > -} > \ No newline at end of file > +} > -- Revert this please.
JF Bastien
Comment 4 2017-04-04 15:49:55 PDT
https://trac.webkit.org/changeset/214909/webkit
Note You need to log in before you can comment on or make changes to this bug.