Bug 170479

Summary: Set lastHandledUserGestureTimestamp on all ancestor documents, not just the top document
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, esprehn+autocc, kangil.han, sam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+
With test for EWS
buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2017-04-04 15:31:32 PDT
Set lastHandledUserGestureTimestamp on all ancestor documents, not just the top document
Attachments
Patch (4.15 KB, patch)
2017-04-04 15:32 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
With test for EWS (10.40 KB, patch)
2017-04-05 16:00 PDT, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (13.21 MB, application/zip)
2017-04-05 17:41 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-04-04 15:32:19 PDT
Created attachment 306218 [details] Patch
Sam Weinig
Comment 2 2017-04-04 16:41:30 PDT
Test case please? Seems like this should be something that can be accessed from internals at the very least.
Simon Fraser (smfr)
Comment 3 2017-04-04 17:48:25 PDT
There's no direct logging for this in internals. I could add some, but this code is going to be tested by upcoming changes.
Sam Weinig
Comment 4 2017-04-04 18:25:26 PDT
(In reply to Simon Fraser (smfr) from comment #3) > There's no direct logging for this in internals. I could add some, but this > code is going to be tested by upcoming changes. That doesn't seem like a great reason not to test it now.
Simon Fraser (smfr)
Comment 5 2017-04-05 16:00:55 PDT
Created attachment 306327 [details] With test for EWS
Build Bot
Comment 6 2017-04-05 17:41:39 PDT
Comment on attachment 306327 [details] With test for EWS Attachment 306327 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3481566 New failing tests: fast/frames/user-gesture-timestamp-propagation.html
Build Bot
Comment 7 2017-04-05 17:41:40 PDT
Created attachment 306344 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 8 2017-04-05 17:55:42 PDT
https://trac.webkit.org/r214982
Note You need to log in before you can comment on or make changes to this bug.