170479 – Set lastHandledUserGestureTimestamp on all ancestor documents, not just the top document

Bug 170479 - Set lastHandledUserGestureTimestamp on all ancestor documents, not just the top document

Summary: Set lastHandledUserGestureTimestamp on all ancestor documents, not just the t...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Simon Fraser (smfr)

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-04-04 15:31 PDT by Simon Fraser (smfr)
Modified:	2017-04-05 17:55 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (4.15 KB, patch) 2017-04-04 15:32 PDT, Simon Fraser (smfr)	sam: review+	Details \| Formatted Diff \| Diff
With test for EWS (10.40 KB, patch) 2017-04-05 16:00 PDT, Simon Fraser (smfr)	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (13.21 MB, application/zip) 2017-04-05 17:41 PDT, Build Bot	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2017-04-04 15:31:32 PDT

Set lastHandledUserGestureTimestamp on all ancestor documents, not just the top document

Comment 1 Simon Fraser (smfr) 2017-04-04 15:32:19 PDT

Created attachment 306218 [details]
Patch

Comment 2 Sam Weinig 2017-04-04 16:41:30 PDT

Test case please? Seems like this should be something that can be accessed from internals at the very least.

Comment 3 Simon Fraser (smfr) 2017-04-04 17:48:25 PDT

There's no direct logging for this in internals. I could add some, but this code is going to be tested by upcoming changes.

Comment 4 Sam Weinig 2017-04-04 18:25:26 PDT

(In reply to Simon Fraser (smfr) from comment #3)
> There's no direct logging for this in internals. I could add some, but this
> code is going to be tested by upcoming changes.

That doesn't seem like a great reason not to test it now.

Comment 5 Simon Fraser (smfr) 2017-04-05 16:00:55 PDT

Created attachment 306327 [details]
With test for EWS

Comment 6 Build Bot 2017-04-05 17:41:39 PDT

Comment on attachment 306327 [details]
With test for EWS

Attachment 306327 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3481566

New failing tests:
fast/frames/user-gesture-timestamp-propagation.html

Comment 7 Build Bot 2017-04-05 17:41:40 PDT

Created attachment 306344 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 8 Simon Fraser (smfr) 2017-04-05 17:55:42 PDT

https://trac.webkit.org/r214982