Bug 170477

Summary: Web Inspector: RTL: fix alignment of "truncated call stack" message
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
LTR - before
none
RTL - before
none
RTL - after
none
Proposed Fix hi: review+

Blaze Burg
Reported 2017-04-04 15:11:44 PDT
oops.
Attachments
LTR - before (43.19 KB, image/png)
2017-04-04 15:11 PDT, Blaze Burg 		no flags
Details
RTL - before (34.22 KB, image/png)
2017-04-04 15:12 PDT, Blaze Burg 		no flags
Details
RTL - after (53.44 KB, image/png)
2017-04-04 15:12 PDT, Blaze Burg 		no flags
Details
Proposed Fix (3.35 KB, patch)
2017-04-04 15:13 PDT, Blaze Burg 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-04-04 15:11:58 PDT
Created attachment 306212 [details] LTR - before
Blaze Burg
Comment 2 2017-04-04 15:12:06 PDT
Created attachment 306213 [details] RTL - before
Blaze Burg
Comment 3 2017-04-04 15:12:21 PDT
Created attachment 306214 [details] RTL - after
Blaze Burg
Comment 4 2017-04-04 15:13:21 PDT
Created attachment 306215 [details] Proposed Fix
Devin Rousso
Comment 5 2017-04-04 16:18:17 PDT
Comment on attachment 306215 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306215&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css:66 > + margin-left: var(--truncated-call-frames-margin-start); > + margin-right: var(--truncated-call-frames-margin-end); NIT: I prefer to follow the shorthand order when using longhand properties. margin-right: var(--truncated-call-frames-margin-end); margin-left: var(--truncated-call-frames-margin-start);
Blaze Burg
Comment 6 2017-04-27 16:12:28 PDT
Committed r215903: <http://trac.webkit.org/changeset/215903>
Note You need to log in before you can comment on or make changes to this bug.