Bug 170477

Summary: Web Inspector: RTL: fix alignment of "truncated call stack" message
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
LTR - before
none
RTL - before
none
RTL - after
none
Proposed Fix hi: review+

Description BJ Burg 2017-04-04 15:11:44 PDT 
oops.
Comment 1 BJ Burg 2017-04-04 15:11:58 PDT 
Created attachment 306212 [details]
LTR - before
Comment 2 BJ Burg 2017-04-04 15:12:06 PDT 
Created attachment 306213 [details]
RTL - before
Comment 3 BJ Burg 2017-04-04 15:12:21 PDT 
Created attachment 306214 [details]
RTL - after
Comment 4 BJ Burg 2017-04-04 15:13:21 PDT 
Created attachment 306215 [details]
Proposed Fix
Comment 5 Devin Rousso 2017-04-04 16:18:17 PDT 
Comment on attachment 306215 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306215&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ThreadTreeElement.css:66
> +    margin-left: var(--truncated-call-frames-margin-start);
> +    margin-right: var(--truncated-call-frames-margin-end);

NIT: I prefer to follow the shorthand order when using longhand properties.

margin-right: var(--truncated-call-frames-margin-end);
margin-left: var(--truncated-call-frames-margin-start);
Comment 6 BJ Burg 2017-04-27 16:12:28 PDT 
Committed r215903: <http://trac.webkit.org/changeset/215903>