Bug 170471

Summary: Move AVSampleBufferDisplayLayer declarations into AVFoundationSPI.h
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170491    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2017-04-04 14:18:36 PDT
Move AVSampleBufferDisplayLayer declarations into AVFoundationSPI.h
Attachments
Patch (4.90 KB, patch)
2017-04-04 14:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.33 KB, patch)
2017-04-04 21:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-04-04 14:20:23 PDT
Created attachment 306204 [details] Patch
WebKit Commit Bot
Comment 2 2017-04-04 15:30:07 PDT
Comment on attachment 306204 [details] Patch Clearing flags on attachment: 306204 Committed r214907: <http://trac.webkit.org/changeset/214907>
WebKit Commit Bot
Comment 3 2017-04-04 15:30:09 PDT
All reviewed patches have been landed. Closing bug.
Jer Noble
Comment 4 2017-04-04 16:33:14 PDT
Follow up build fix: Committed r214912: <https://trac.webkit.org/r214912>
WebKit Commit Bot
Comment 5 2017-04-04 20:23:45 PDT
Re-opened since this is blocked by bug 170491
Jer Noble
Comment 6 2017-04-04 21:59:24 PDT
Created attachment 306250 [details] Patch for landing
Build Bot
Comment 7 2017-04-04 22:00:53 PDT
Attachment 306250 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:198: Missing spaces around / [whitespace/operators] [3] ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:224: Missing spaces around / [whitespace/operators] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2017-04-04 22:38:29 PDT
Comment on attachment 306250 [details] Patch for landing Clearing flags on attachment: 306250 Committed r214930: <http://trac.webkit.org/changeset/214930>
WebKit Commit Bot
Comment 9 2017-04-04 22:38:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.