Summary: | Web Inspector: Include more Network information in Resource Details Sidebar | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, inspector-bugzilla-changes, joepeck, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-04-04 14:16:34 PDT
Created attachment 306202 [details]
[PATCH] Proposed Fix
Created attachment 306203 [details]
[IMAGE] New Sidebar Data
Comment on attachment 306202 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306202&action=review r=me, nice. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:202 > +localizedStrings["Connection ID"] = "Connection ID"; ID or identifier? (In reply to Brian Burg from comment #3) > Comment on attachment 306202 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306202&action=review > > r=me, nice. > > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:202 > > +localizedStrings["Connection ID"] = "Connection ID"; > > ID or identifier? Because this is a table header a long name just gets truncated. Let's go with the shorter name. Comment on attachment 306202 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306202 Committed r214903: <http://trac.webkit.org/changeset/214903> All reviewed patches have been landed. Closing bug. |