Bug 170468

Summary:

Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, dbates, esprehn+autocc, gyuyoung.kim, japhet, kangil.han, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Simon Fraser (smfr) 2017-04-04 13:48:50 PDT

Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime

Comment 1 Simon Fraser (smfr) 2017-04-04 13:49:31 PDT

Created attachment 306196 [details]
Patch

Comment 2 Simon Fraser (smfr) 2017-04-04 14:32:58 PDT

https://trac.webkit.org/r214900

Comment 3 Chris Dumez 2017-04-04 14:32:59 PDT

Comment on attachment 306196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306196&action=review

> Source/WebCore/loader/FrameLoader.cpp:3039
> +    bool userDidInteractWithPage = static_cast<bool>(document.topDocument().lastHandledUserGestureTimestamp());

I personally like:
!!document.topDocument().lastHandledUserGestureTimestamp()

for this sort of things as it is shorter than a cast.