Bug 170448

Summary: AX: Don't crash if no renderer is available for AccessibilityRenderObject
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: AccessibilityAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, dmazzoni, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Tomas Popela 2017-04-04 04:10:10 PDT 
Don't crash or assert if no renderer is available, but early return gracefully (as in other places in the AccessibilityRenderObject.cpp). Spotted by running some tests through dogtail.
Comment 1 Tomas Popela 2017-04-04 04:21:55 PDT 
Created attachment 306170 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-04-04 04:22:40 PDT 
<rdar://problem/31425088>
Comment 3 chris fleizach 2017-04-04 07:01:54 PDT 
Comment on attachment 306170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306170&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:535
> +        return false;

I think if this was true I would be more accurate
Comment 4 Tomas Popela 2017-04-06 02:48:47 PDT 
Created attachment 306372 [details]
Patch
Comment 5 Tomas Popela 2017-04-07 04:59:36 PDT 
Comment on attachment 306372 [details]
Patch

Clearing flags on attachment: 306372

Committed r215089: <http://trac.webkit.org/changeset/215089>
Comment 6 Tomas Popela 2017-04-07 04:59:42 PDT 
All reviewed patches have been landed.  Closing bug.