Bug 170430

Summary: TestWebKitAPI: Warning: Multiple build commands for Ahem.ttf
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, joepeck, lforschler, mitz, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-04-03 16:04:53 PDT
When building TestWebKitAPI there is a warning: Warning: Multiple build commands for output file /Build/Release/TestWebKitAPI.resources/Ahem.ttf There are two identical copies of Ahem.ttf in the project. We only need one.
Attachments
[PATCH] Proposed Fix (76.02 KB, patch)
2017-04-03 16:10 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-04-03 16:10:08 PDT
Created attachment 306135 [details] [PATCH] Proposed Fix Tested with: $ rm -rf $build/TestWebKitAPI* $ run-api-tests WebKit1.CancelLoadFromResourceLoadDelegate CancelLoading.CancelFontSubresource Running build-api-tests PASS CancelLoading.CancelFontSubresource PASS WebKit1.CancelLoadFromResourceLoadDelegate This will make it harder to just open TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html from the source directory, because "Ahem.ttf" is not in that directory but we use the one in TestWebKitAPI/Tests/WebKit2/Ahem.ttf. I think thats fine, because what really matters is run-api-tests.
Joseph Pecoraro
Comment 2 2017-04-03 16:10:33 PDT
> $ rm -rf $build/TestWebKitAPI* Err, in this case $build/Release/TestWebKitAPI*
WebKit Commit Bot
Comment 3 2017-04-03 17:42:57 PDT
Comment on attachment 306135 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306135 Committed r214858: <http://trac.webkit.org/changeset/214858>
WebKit Commit Bot
Comment 4 2017-04-03 17:42:59 PDT
All reviewed patches have been landed. Closing bug.
Myles C. Maxfield
Comment 5 2017-04-07 17:33:12 PDT
Thanks, Joe!
Note You need to log in before you can comment on or make changes to this bug.