Web Inspector: RTL: layout issues in debugger dashboard, arrows are on wrong side

• Component: Web Inspector
• Status: RESOLVED FIXED

[BJ Burg]

Whoopsy.

[BJ Burg]

Created attachment 306125 [details]
Proposed Fix

[BJ Burg]

Created attachment 306126 [details]
RTL - debug dashboard - before

[BJ Burg]

Created attachment 306127 [details]
RTL - default dashboard - before

[BJ Burg]

Created attachment 306128 [details]
RTL - debug dashboard - after

[BJ Burg]

Created attachment 306129 [details]
LTR - debug dashboard - after

[Devin Rousso]

Comment on attachment 306125 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=306125&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152
> +    --dashboard-advance-arrow-end: 0px;

I think we are using "offset" to represent positioning values in CSS variable names.

--dashboard-advance-arrow-offset-end: 0;

[BJ Burg]

(In reply to Devin Rousso from comment #6)
> Comment on attachment 306125 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306125&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css:152
> > +    --dashboard-advance-arrow-end: 0px;
> 
> I think we are using "offset" to represent positioning values in CSS
> variable names.
> 
> --dashboard-advance-arrow-offset-end: 0;

OK

[BJ Burg]

Created attachment 306189 [details]
For Landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 306189 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 306189 [details]
For Landing

Clearing flags on attachment: 306189

Committed r214899: <http://trac.webkit.org/changeset/214899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.