Bug 170424

Summary: AX: Expose link children when doing search predication on iOS
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Nan Wang
Reported 2017-04-03 15:02:45 PDT
Since the children of the links are exposed on iOS instead of the link itself most of the time. We should expose the children when doing search predication.
Attachments
patch (9.99 KB, patch)
2017-04-03 15:14 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (9.99 KB, patch)
2017-04-03 15:37 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nan Wang
Comment 1 2017-04-03 15:07:54 PDT
<rdar://problem/31413335>
Nan Wang
Comment 2 2017-04-03 15:14:24 PDT
Created attachment 306123 [details] patch
chris fleizach
Comment 3 2017-04-03 15:27:46 PDT
Comment on attachment 306123 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review > Source/WebCore/ChangeLog:7 > + Since the children of the links are exposed on iOS instead of the link itself The children of links are accessible elements on iOS instead of the link itself, so we should expose the children when doing predicated searches as well. > Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665 > + NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly); any reason you chose five?
Nan Wang
Comment 4 2017-04-03 15:30:00 PDT
Comment on attachment 306123 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review >> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665 >> + NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly); > > any reason you chose five? I just picked a number thats greater than 1, and I think 5 should be enough for normal test cases. Do you have any suggestion ?
chris fleizach
Comment 5 2017-04-03 15:34:11 PDT
Comment on attachment 306123 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306123&action=review >>> Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:665 >>> + NSDictionary *parameterizedAttribute = searchPredicateParameterizedAttributeForSearchCriteria(context, startElement, isDirectionNext, 5, searchKey, searchText, visibleOnly, immediateDescendantsOnly); >> >> any reason you chose five? > > I just picked a number thats greater than 1, and I think 5 should be enough for normal test cases. Do you have any suggestion ? probably fine as is
Nan Wang
Comment 6 2017-04-03 15:37:38 PDT
Created attachment 306132 [details] patch updated from review
WebKit Commit Bot
Comment 7 2017-04-03 16:06:28 PDT
Comment on attachment 306132 [details] patch Clearing flags on attachment: 306132 Committed r214851: <http://trac.webkit.org/changeset/214851>
WebKit Commit Bot
Comment 8 2017-04-03 16:06:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.