Bug 170420

Summary:

Web Inspector: "Space" is not localizable in Timelines record button tooltips

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2017-04-03 14:23:17 PDT

Summary: "Space" is not localizable in Timelines record button tooltips Steps to Reproduce: 1. Inspect this page 2. Show Timelines tab 3. Show Tooltip for Record button => "Start Recording (Space)" Notes: The "Start Recording" part is localizable, but the keyboard shortcut part "Space" is not. It should be.

Attachments
[PATCH] Proposed Fix (5.97 KB, patch) 2017-04-03 14:26 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-04-03 14:23:30 PDT

<rdar://problem/30871371>

Joseph Pecoraro

Comment 2 2017-04-03 14:26:34 PDT

Created attachment 306116 [details] [PATCH] Proposed Fix

Blaze Burg

Comment 3 2017-04-03 14:50:12 PDT

Comment on attachment 306116 [details] [PATCH] Proposed Fix r=me too :)

WebKit Commit Bot

Comment 4 2017-04-03 15:06:27 PDT

Comment on attachment 306116 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306116 Committed r214841: <http://trac.webkit.org/changeset/214841>

WebKit Commit Bot

Comment 5 2017-04-03 15:06:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.