Bug 170420 - Web Inspector: "Space" is not localizable in Timelines record button tooltips
Summary: Web Inspector: "Space" is not localizable in Timelines record button tooltips
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-04-03 14:23 PDT by Joseph Pecoraro
Modified: 2017-04-03 15:06 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.97 KB, patch)
2017-04-03 14:26 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-04-03 14:23:17 PDT
Summary:
"Space" is not localizable in Timelines record button tooltips

Steps to Reproduce:
1. Inspect this page
2. Show Timelines tab
3. Show Tooltip for Record button
  => "Start Recording (Space)"

Notes:
The "Start Recording" part is localizable, but the keyboard shortcut part "Space" is not. It should be.
Comment 1 Joseph Pecoraro 2017-04-03 14:23:30 PDT
<rdar://problem/30871371>
Comment 2 Joseph Pecoraro 2017-04-03 14:26:34 PDT
Created attachment 306116 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2017-04-03 14:50:12 PDT
Comment on attachment 306116 [details]
[PATCH] Proposed Fix

r=me too :)
Comment 4 WebKit Commit Bot 2017-04-03 15:06:27 PDT
Comment on attachment 306116 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 306116

Committed r214841: <http://trac.webkit.org/changeset/214841>
Comment 5 WebKit Commit Bot 2017-04-03 15:06:29 PDT
All reviewed patches have been landed.  Closing bug.