Bug 170414
| Summary: | Support InputEvent.isComposing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chong Zhang <chongz> |
| Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | 709922234, ahmad.saleem792, ap, bdakin, bfulgham, rniwa, simon.fraser, webkit-bug-importer, webkit, wenson_hsieh, zalan |
| Priority: | P2 | Keywords: | FromImplementor, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://w3c.github.io/uievents/#dom-inputevent-iscomposing | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=170416 | ||
Chong Zhang
According to spec https://w3c.github.io/uievents/#events-inputevents InputEvent should have attribute |isComposing| to indicate whether it's inside a composition.
Blink IDL:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/InputEvent.idl?q=InputEvent.idl&sq=package:chromium&dr&l=16
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Wenson Hsieh
<rdar://problem/31781958>
Ahmad Saleem
Updated link to Chromium / Blink source - https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/events/input_event.idl;l=1?q=INput_event.idl&sq=
Webkit Source - https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/dom/InputEvent.idl
_____________
Need to change:
constructor(DOMString type, optional InputEventInit eventInitDict = {});
Add:
readonly attribute boolean isComposing;
Extra in Webkit:
dictionary InputEventInit : UIEventInit {
DOMString? data = null;
};
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/3990
EWS
Committed 254131@main (1aeb3328d18e): <https://commits.webkit.org/254131@main>
Reviewed commits have been landed. Closing PR #3990 and removing active labels.