Summary: | Mac cmake buildfix after 214586 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, benjamin, buildbot, cdumez, cmarcelo, darin, dbates, ossy, thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 161675 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2017-04-01 04:00:19 PDT
Created attachment 306046 [details]
Patch
patch for EWS
Comment on attachment 306046 [details] Patch Clearing flags on attachment: 306046 Committed r214716: <http://trac.webkit.org/changeset/214716> All reviewed patches have been landed. Closing bug. Committed r214717: <http://trac.webkit.org/changeset/214717> forgot to mention https://trac.webkit.org/changeset/214715/webkit which was the first fix after the following build error: /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:29:9: fatal error: 'EventSerializerMac.h' file not found #import "EventSerializerMac.h" ^ Still broken ... Undefined symbols for architecture x86_64: "_OBJC_CLASS_$_EventStreamPlayer", referenced from: objc-class-ref in UIScriptControllerMac.mm.o "beginSwipeBackEventStream()", referenced from: WTR::UIScriptController::beginBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o "completeSwipeBackEventStream()", referenced from: WTR::UIScriptController::completeBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [bin/WebKitTestRunner] Error 1 make[1]: *** [Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/all] Error 2 ... /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:59:38: error: unknown type name 'CGSEventType'; did you mean 'CGEventType'? bool eventIsOfType(CGEventRef event, CGSEventType type) ^~~~~~~~~~~~ CGEventType ... unassign, I don't have time for it, maybe Alex? |