Bug 170374

Summary: WebAssembly: Add compilation level option
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Keith Miller
Reported 2017-03-31 17:41:37 PDT
WebAssembly: Add compilation level option
Attachments
Patch (3.14 KB, patch)
2017-03-31 17:44 PDT, Keith Miller 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-03-31 17:44:28 PDT
Created attachment 306031 [details] Patch
Mark Lam
Comment 2 2017-03-31 17:46:39 PDT
Comment on attachment 306031 [details] Patch r=me
Keith Miller
Comment 3 2017-03-31 17:48:01 PDT
Committed r214708: <http://trac.webkit.org/changeset/214708>
Mark Lam
Comment 4 2017-03-31 17:48:21 PDT
Comment on attachment 306031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306031&action=review > Source/JavaScriptCore/wasm/WasmPlan.cpp:248 > + auto parseAndCompileResult = parseAndCompile(m_compilationContexts[functionIndex], functionStart, functionLength, signature, m_unlinkedWasmToWasmCalls[functionIndex], *m_moduleInformation, m_moduleSignatureIndicesToUniquedSignatureIndices, m_mode, Options::webAssemblyB3OptimizationLevel()); The current implementation uses "unsigned optLevel = B3::defaultOptLevel()" in the header file. Shouldn't you get rid of that since it's no longer used?
Note You need to log in before you can comment on or make changes to this bug.