Bug 170373

Summary:

REGRESSION(r213682): Web Inspector: Network columns don't get saved when Web Inspector is closed

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Nikita Vasilyev

Reported 2017-03-31 17:18:43 PDT

Steps: 1. Open Network tab. 2. Right click on one of the column headers, such as Domain. 3. Uncheck Domain to hide it. 4. Close Web Inspector. 5. Open Web Inspector. Expected: Domain column stays hidden. Actual: Domain column is visible. No matter what changes in column visibility were made, they don't get saved.

Attachments
[PATCH] Proposed Fix (2.14 KB, patch) 2017-04-17 15:36 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-03-31 20:57:43 PDT

<rdar://problem/31386336>

Joseph Pecoraro

Comment 2 2017-04-17 15:33:44 PDT

I don't think this was ever working.

Joseph Pecoraro

Comment 3 2017-04-17 15:36:42 PDT

Created attachment 307307 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 4 2017-04-17 15:39:32 PDT

NVI corrects me, this was working in the past. In that case, this would have regressed with: <https://trac.webkit.org/r213682> Which made it possible to save the hidden/visible state of default hidden columns. It didn't work for default visible columns because `columnInfo.hidden` was undefined.

Nikita Vasilyev

Comment 5 2017-04-17 15:44:59 PDT

Comment on attachment 307307 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=307307&action=review Looks good to me. > Source/WebInspectorUI/ChangeLog:14 > + we always get an explicit boolean. This is indeed what was happening.

Matt Baker

Comment 6 2017-04-17 21:23:59 PDT

Comment on attachment 307307 [details] [PATCH] Proposed Fix r=me. I think eventually it would be nice to have a DataGridColumn object that sanitizes these types of settings.

WebKit Commit Bot

Comment 7 2017-04-17 21:55:43 PDT

Comment on attachment 307307 [details] [PATCH] Proposed Fix Clearing flags on attachment: 307307 Committed r215449: <http://trac.webkit.org/changeset/215449>

WebKit Commit Bot

Comment 8 2017-04-17 21:55:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.