Bug 170357

Summary:

Fix memory leak in CreateSessionDescriptionObserver::OnSuccess

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ggaren

Priority:

P2

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

youenn fablet

Reported 2017-03-31 13:44:23 PDT

Passed raw pointer should be released.

Attachments
Patch (1.80 KB, patch) 2017-03-31 13:45 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (2.90 KB, patch) 2017-04-03 09:31 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-03-31 13:45:36 PDT

Created attachment 306007 [details] Patch

Geoffrey Garen

Comment 2 2017-03-31 14:56:17 PDT

Comment on attachment 306007 [details] Patch r=me

WebKit Commit Bot

Comment 3 2017-03-31 15:05:25 PDT

Comment on attachment 306007 [details] Patch Clearing flags on attachment: 306007 Committed r214689: <http://trac.webkit.org/changeset/214689>

WebKit Commit Bot

Comment 4 2017-03-31 15:05:28 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2017-03-31 16:35:45 PDT

This change caused a lot of crashes, rolling back. https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214689%20(330)/results.html

Alexey Proskuryakov

Comment 6 2017-03-31 16:59:35 PDT

Rolled back in r214700.

youenn fablet

Comment 7 2017-03-31 17:16:18 PDT

Ah right, I should have updated libwebrtc mock. Will reland with mick updated

youenn fablet

Comment 8 2017-04-03 08:41:26 PDT

Reopening to fix mock

youenn fablet

Comment 9 2017-04-03 09:31:31 PDT

Created attachment 306077 [details] Patch

Note You need to log in before you can comment on or make changes to this bug.