Bug 170315

Summary:

Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Sam Weinig 2017-03-30 17:14:20 PDT

Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI

Comment 1 Sam Weinig 2017-03-30 17:16:48 PDT

<rdar://problem/31350588>

Comment 2 Sam Weinig 2017-03-30 17:16:54 PDT

Created attachment 305930 [details]
Patch

Comment 3 Simon Fraser (smfr) 2017-03-30 17:35:15 PDT

Comment on attachment 305930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305930&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:5033
> +    auto copiedCompletionHandler = Block_copy(completionHandler);

Should this use makeBlockPtr?

Comment 4 Sam Weinig 2017-03-30 17:45:08 PDT

Committed r214643: <http://trac.webkit.org/changeset/214643>