Bug 170315

Summary: Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Sam Weinig
Reported 2017-03-30 17:14:20 PDT
Expose the WKView SPI, _prepareForMoveToWindow:withCompletionHandler as WKWebView SPI
Attachments
Patch (9.49 KB, patch)
2017-03-30 17:16 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-03-30 17:16:48 PDT
<rdar://problem/31350588>
Sam Weinig
Comment 2 2017-03-30 17:16:54 PDT
Created attachment 305930 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-03-30 17:35:15 PDT
Comment on attachment 305930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305930&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:5033 > + auto copiedCompletionHandler = Block_copy(completionHandler); Should this use makeBlockPtr?
Sam Weinig
Comment 4 2017-03-30 17:45:08 PDT
Committed r214643: <http://trac.webkit.org/changeset/214643>
Note You need to log in before you can comment on or make changes to this bug.