Bug 17029

Summary: Use of deprecated class function but declares GTK_DISABLE_DEPRECATED
Product: WebKit Reporter: Stephan Binner <stbinner>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Sync bundled code with Mozilla mrowe: review+

Stephan Binner
Reported 2008-01-27 03:44:12 PST
> E: WebKitGtk 64bit-portability-issue ../../WebCore/platform/gtk/gtk2drawing.c: 203 gtk2drawing.c used gtk_option_menu_new() while the build system defines GTK_DISABLE_DEPRECATED, result: gtk_option_menu_new() is rather undefined.
Attachments
Sync bundled code with Mozilla (98.84 KB, patch)
2008-01-27 15:54 PST, Alp Toker 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alp Toker
Comment 1 2008-01-27 15:54:10 PST
Created attachment 18729 [details] Sync bundled code with Mozilla gtkdrawing.h and gtk2drawing.c are bundled sources so no need to review them too closely
Alp Toker
Comment 2 2008-01-27 16:14:16 PST
Thanks! Fix landed in r29824. (Just to be clear, this build error would only have showed up in debug builds. WebKit debug builds are quite different from release builds, being heavily instrumented and not suitable for deployment.)
Note You need to log in before you can comment on or make changes to this bug.