Bug 170266

Summary: WebAssembly: B3IRGenerator should pool constants
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Keith Miller
Reported 2017-03-29 19:10:40 PDT
WebAssembly: B3IRGenerator should pool constants
Attachments
Patch (27.96 KB, patch)
2017-03-29 19:18 PDT, Keith Miller 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-03-29 19:18:13 PDT
Created attachment 305820 [details] Patch
Filip Pizlo
Comment 2 2017-03-29 19:25:26 PDT
Comment on attachment 305820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305820&action=review seems legit > Source/JavaScriptCore/b3/B3Procedure.h:121 > + // bits is a bitwise_cast of the constant you want. > + Value* addConstant(Origin, Type, uint64_t bits); Nice
Keith Miller
Comment 3 2017-03-29 19:39:56 PDT
Committed r214592: <http://trac.webkit.org/changeset/214592>
Note You need to log in before you can comment on or make changes to this bug.