[css-grid] Update W3C Test Suite

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Manuel Rego Casasnovas]

Some new tests have been added to the W3C Test Suite as reqested in https://bugs.webkit.org/show_bug.cgi?id=163200#c7
It'd be nice to get them imported into WebKit.

[Manuel Rego Casasnovas]

Created attachment 305575 [details]
Patch

[youenn fablet]

Comment on attachment 305575 [details]
Patch

r = me.
Although, it may be better to wait a day or two so that these tests are migrated to web-platform-tests on GitHub and do the migration here as well. Migration is due today or so.

[youenn fablet]

Yes, https://github.com/w3c/csswg-test is now deprecated.
Would you be able to import https://github.com/w3c/web-platform-tests/tree/master/css/css-grid-1 instead?

[Manuel Rego Casasnovas]

Created attachment 305722 [details]
Patch

[Manuel Rego Casasnovas]

(In reply to youenn fablet from comment #3)
> Yes, https://github.com/w3c/csswg-test is now deprecated.
> Would you be able to import
> https://github.com/w3c/web-platform-tests/tree/master/css/css-grid-1 instead?

Yeah I've imported the new path instead, please take another look just in case I missed anything.
Thanks!

[WebKit Commit Bot]

Comment on attachment 305722 [details]
Patch

Rejecting attachment 305722 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 305722, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3441355

[Manuel Rego Casasnovas]

Created attachment 305872 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 305872 [details]
Patch for landing

Clearing flags on attachment: 305872

Committed r214660: <http://trac.webkit.org/changeset/214660>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.