Bug 170170 - [css-grid] Update W3C Test Suite
Summary: [css-grid] Update W3C Test Suite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2017-03-28 02:10 PDT by Manuel Rego Casasnovas
Modified: 2017-03-31 02:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (90.60 KB, patch)
2017-03-28 02:14 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (1.34 MB, patch)
2017-03-29 03:01 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch for landing (1.34 MB, patch)
2017-03-30 12:31 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2017-03-28 02:10:03 PDT
Some new tests have been added to the W3C Test Suite as reqested in https://bugs.webkit.org/show_bug.cgi?id=163200#c7
It'd be nice to get them imported into WebKit.
Comment 1 Manuel Rego Casasnovas 2017-03-28 02:14:06 PDT
Created attachment 305575 [details]
Patch
Comment 2 youenn fablet 2017-03-28 09:08:02 PDT
Comment on attachment 305575 [details]
Patch

r = me.
Although, it may be better to wait a day or two so that these tests are migrated to web-platform-tests on GitHub and do the migration here as well. Migration is due today or so.
Comment 3 youenn fablet 2017-03-28 09:28:54 PDT
Yes, https://github.com/w3c/csswg-test is now deprecated.
Would you be able to import https://github.com/w3c/web-platform-tests/tree/master/css/css-grid-1 instead?
Comment 4 Manuel Rego Casasnovas 2017-03-29 03:01:52 PDT
Created attachment 305722 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2017-03-29 03:03:05 PDT
(In reply to youenn fablet from comment #3)
> Yes, https://github.com/w3c/csswg-test is now deprecated.
> Would you be able to import
> https://github.com/w3c/web-platform-tests/tree/master/css/css-grid-1 instead?

Yeah I've imported the new path instead, please take another look just in case I missed anything.
Thanks!
Comment 6 WebKit Commit Bot 2017-03-30 09:33:30 PDT
Comment on attachment 305722 [details]
Patch

Rejecting attachment 305722 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 305722, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3441355
Comment 7 Manuel Rego Casasnovas 2017-03-30 12:31:02 PDT
Created attachment 305872 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-03-31 02:27:23 PDT
Comment on attachment 305872 [details]
Patch for landing

Clearing flags on attachment: 305872

Committed r214660: <http://trac.webkit.org/changeset/214660>
Comment 9 WebKit Commit Bot 2017-03-31 02:27:24 PDT
All reviewed patches have been landed.  Closing bug.