Summary: | Web Inspector: Probe values not showing in sidebar | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-03-27 15:05:01 PDT
I think this is being caused by the way WebInspector.ProbeSetDataGrid is being used by WebInspector.ProbeSetDetailsSection. Since WebInspector.DetailsSection is not yet a subclass of WebInspector.View, the check for `_isAttachedToRoot` fails as it's not a subview of the root, instead being added manually by calling `appendChild` on the actual element. Created attachment 306304 [details]
Patch
Comment on attachment 306304 [details]
Patch
r=me
Comment on attachment 306304 [details] Patch Clearing flags on attachment: 306304 Committed r214967: <http://trac.webkit.org/changeset/214967> All reviewed patches have been landed. Closing bug. |