Bug 170139

Summary:

Add some missing NetworkResourceLoader logging

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

WebKit2

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Patch	none

Keith Rollin

Reported 2017-03-27 13:55:46 PDT

Execution can enter the lambda in NetworkResourceLoader::retrieveCacheEntry, without there being much indication of which exit point was taken. If flow enters into startNetworkLoad, we'll get some logging from that function, but not from the others. Add some logging so that we know what the result was from looking up the resource in the cache. Having this logging would have helped in the tracking down of situations where we see in the logs that a resource is starting to be loaded but then there's no logging saying what ultimately happened to it.

Attachments
Patch (6.04 KB, patch) 2017-03-27 14:19 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Patch (4.22 KB, patch) 2017-04-11 14:01 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (913.23 KB, application/zip) 2017-04-11 15:19 PDT, Build Bot	no flags	Details
Patch (4.22 KB, patch) 2017-04-12 13:24 PDT, Keith Rollin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Keith Rollin

Comment 1 2017-03-27 14:19:49 PDT

Created attachment 305507 [details] Patch

Alex Christensen

Comment 2 2017-04-05 06:55:08 PDT

Comment on attachment 305507 [details] Patch More logs. r=me. I think it's unnecessary to add a new function for this.

Keith Rollin

Comment 3 2017-04-11 14:01:56 PDT

Created attachment 306848 [details] Patch

Build Bot

Comment 4 2017-04-11 15:19:08 PDT

Comment on attachment 306848 [details] Patch Attachment 306848 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3519196 New failing tests: webrtc/negotiatedneeded-event-addStream.html

Build Bot

Comment 5 2017-04-11 15:19:09 PDT

Created attachment 306863 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Keith Rollin

Comment 6 2017-04-12 13:24:12 PDT

Created attachment 306931 [details] Patch

WebKit Commit Bot

Comment 7 2017-04-12 14:46:13 PDT

Comment on attachment 306931 [details] Patch Clearing flags on attachment: 306931 Committed r215294: <http://trac.webkit.org/changeset/215294>

WebKit Commit Bot

Comment 8 2017-04-12 14:46:14 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.