| Summary: | webkitpy: Use host pattern for devices | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, dbates, ddkilzer, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2017-03-27 10:49:49 PDT
Created attachment 305484 [details]
Patch
Comment on attachment 305484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305484&action=review > Tools/ChangeLog:9 > + throughout webkitpy. Add the needed properties and This sentence does not read well. > Tools/Scripts/webkitpy/port/device.py:36 > + try: Is it necessary to use a try-catch? I do not see the harm in having a Python exception thrown if this property does not exist in the platform device. Such an exception would tell us either that we need to implement this functionality or that the caller must conditionalize the call to this property. > Tools/Scripts/webkitpy/port/device.py:43 > + try: Ditto. > Tools/Scripts/webkitpy/port/device.py:50 > + try: Ditto > Tools/Scripts/webkitpy/port/device.py:57 > + try: Ditto. > Tools/Scripts/webkitpy/port/device.py:64 > + try: Ditto. Created attachment 305516 [details]
Patch
Comment on attachment 305516 [details] Patch Clearing flags on attachment: 305516 Committed r214473: <http://trac.webkit.org/changeset/214473> All reviewed patches have been landed. Closing bug. |