| Summary: | [GTK] NetscapePluginX11::m_windowID is unused/unneeded | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bugs-noreply, cgarcia, commit-queue, darin, ggaren, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 305461 [details]
Patch
JFTR, the failures in the Windows/Mac EWSs seem completely unrelated. (Also: the lines changed are guarded with “PLATFORM(GTK)”) Comment on attachment 305461 [details] Patch Clearing flags on attachment: 305461 Committed r214412: <http://trac.webkit.org/changeset/214412> All reviewed patches have been landed. Closing bug. |
Building WebKitGTK+ with Clang produces the following warning: Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:67:14: warning: private field 'm_windowID' is not used [-Wunused-private-field] uint64_t m_windowID { 0 }; ^ The “windowID” parameter is still needed in the constructor, as it gets passed to “gtk_plug_new()”, but that is the only use. I'll be sending a patch to remove the unneeded “m_windowID” member.