Bug 170115

Summary: [GTK] NetscapePluginX11::m_windowID is unused/unneeded
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bugs-noreply, cgarcia, commit-queue, darin, ggaren, mcatanzaro
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-03-27 03:49:21 PDT
Building WebKitGTK+ with Clang produces the following warning: Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:67:14: warning: private field 'm_windowID' is not used [-Wunused-private-field] uint64_t m_windowID { 0 }; ^ The “windowID” parameter is still needed in the constructor, as it gets passed to “gtk_plug_new()”, but that is the only use. I'll be sending a patch to remove the unneeded “m_windowID” member.
Attachments
Patch (2.37 KB, patch)
2017-03-27 03:54 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-03-27 03:54:57 PDT
Created attachment 305461 [details] Patch
Adrian Perez
Comment 2 2017-03-27 05:02:36 PDT
JFTR, the failures in the Windows/Mac EWSs seem completely unrelated. (Also: the lines changed are guarded with “PLATFORM(GTK)”)
WebKit Commit Bot
Comment 3 2017-03-27 06:38:38 PDT
Comment on attachment 305461 [details] Patch Clearing flags on attachment: 305461 Committed r214412: <http://trac.webkit.org/changeset/214412>
WebKit Commit Bot
Comment 4 2017-03-27 06:38:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.