| Summary: | REGRESSION (r214354): Web Inspector: WebSocket connection icon obscures close content view icon | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mattbaker | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 305513 [details]
Patch
(In reply to Devin Rousso from comment #1) > Created attachment 305513 [details] > Patch This patch removes any indicator from the Network tab. I feel this is fine since there is more information (such as the increasing size or the waterfall) that a Socket is still alive. Could we display the connection status icon in the subtitle part of the tree element? (we'd want to hide the em-dash separator if we tried this) Comment on attachment 305513 [details]
Patch
r=me, This sounds fine to me.
Comment on attachment 305513 [details] Patch Clearing flags on attachment: 305513 Committed r214839: <http://trac.webkit.org/changeset/214839> All reviewed patches have been landed. Closing bug. |
Created attachment 305412 [details] [Image] Bug Regressed when this icon was introduced. I still like the Matt's idea of indicating the connection status by replacing or perhaps augmenting the document icon.