Bug 17008

Summary: Meta refresh does not work with cache turned off
Product: WebKit Reporter: Adam Treat <manyoso>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: alp, ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
cache_fix mitz: review-

Adam Treat
Reported 2008-01-25 09:49:01 PST
The following website does not work when the cache is turned off for instance: http://adserver.vivox.com/2 The attached patch fixes this.
Attachments
cache_fix (775 bytes, patch)
2008-01-25 09:50 PST, Adam Treat 		mitz: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Treat
Comment 1 2008-01-25 09:50:03 PST
Created attachment 18692 [details] cache_fix
Mark Rowe (bdash)
Comment 2 2008-01-26 02:00:03 PST
The patch needs a ChangeLog entry.
Eric Seidel (no email)
Comment 3 2008-01-28 23:30:00 PST
Comment on attachment 18692 [details] cache_fix Great fix. Needs a change log (As mark noted) as well as ideally a test case. I guess it's hard to test disabling the cache with DRT. However, it should be possible to make a manual test case and put it in WebCore/manual-tests/
Adam Treat
Comment 4 2008-01-29 06:32:23 PST
Ok, great. I'll create a Changelog entry of course. I just wanted to know if I was barking up the right tree first.
Alp Toker
Comment 5 2008-02-17 16:16:22 PST
I wrote a rudimentary ChangeLog entry for this and landed it in r30360 to get it out of pending-commit.
Sam Weinig
Comment 6 2008-02-17 22:46:53 PST
Reopening. The patch had to be rolled out in r30368 as it was causing crashes.
mitz
Comment 7 2008-02-17 22:51:20 PST
Comment on attachment 18692 [details] cache_fix
Adam Treat
Comment 8 2009-01-05 06:50:18 PST
Can you elaborate on how this was causing crashes if you remember? Perhaps it can be fixed if the crash is known?
Note You need to log in before you can comment on or make changes to this bug.