Bug 17008 - Meta refresh does not work with cache turned off
Summary: Meta refresh does not work with cache turned off
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-25 09:49 PST by Adam Treat
Modified: 2010-06-10 16:27 PDT (History)
2 users (show)

See Also:

Attachments
cache_fix (775 bytes, patch)
2008-01-25 09:50 PST, Adam Treat 		mitz: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2008-01-25 09:49:01 PST 
The following website does not work when the cache is turned off for instance:

http://adserver.vivox.com/2

The attached patch fixes this.
Comment 1 Adam Treat 2008-01-25 09:50:03 PST 
Created attachment 18692 [details]
cache_fix
Comment 2 Mark Rowe (bdash) 2008-01-26 02:00:03 PST 
The patch needs a ChangeLog entry.
Comment 3 Eric Seidel (no email) 2008-01-28 23:30:00 PST 
Comment on attachment 18692 [details]
cache_fix

Great fix.  Needs a change log (As mark noted) as well as ideally a test case.  I guess it's hard to test disabling the cache with DRT.  However, it should be possible to make a manual test case and put it in WebCore/manual-tests/
Comment 4 Adam Treat 2008-01-29 06:32:23 PST 
Ok, great.  I'll create a Changelog entry of course.  I just wanted to know if I was barking up the right tree first.
Comment 5 Alp Toker 2008-02-17 16:16:22 PST 
I wrote a rudimentary ChangeLog entry for this and landed it in r30360 to get it out of pending-commit.
Comment 6 Sam Weinig 2008-02-17 22:46:53 PST 
Reopening.  The patch had to be rolled out in r30368 as it was causing crashes.
Comment 7 mitz 2008-02-17 22:51:20 PST 
Comment on attachment 18692 [details]
cache_fix
Comment 8 Adam Treat 2009-01-05 06:50:18 PST 
Can you elaborate on how this was causing crashes if you remember?  Perhaps it can be fixed if the crash is known?