Bug 170078

Summary: webkitpy: Use generalized device instead of platform specific one
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2017-03-24 15:41:36 PDT
When testing on devices, pass a generalized device interface instead of a specific platform device. The generalized device should be persistent.
Attachments
Patch (10.11 KB, patch)
2017-03-24 15:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (11.84 KB, patch)
2017-03-24 16:00 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (12.28 KB, patch)
2017-03-24 16:36 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2017-03-24 15:44:04 PDT
Created attachment 305327 [details] Patch
Jonathan Bedard
Comment 2 2017-03-24 16:00:48 PDT
Created attachment 305331 [details] Patch
Daniel Bates
Comment 3 2017-03-24 16:12:44 PDT
Comment on attachment 305331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305331&action=review > Tools/ChangeLog:10 > + no longer inherits from Device and IOSSimulator returns Devices > + wrapping SimulatedDevices. We should explain why we are making this change.
Radar WebKit Bug Importer
Comment 4 2017-03-24 16:29:50 PDT
<rdar://problem/31253119>
Jonathan Bedard
Comment 5 2017-03-24 16:36:19 PDT
Created attachment 305338 [details] Patch
WebKit Commit Bot
Comment 6 2017-03-25 07:44:29 PDT
Comment on attachment 305338 [details] Patch Clearing flags on attachment: 305338 Committed r214399: <http://trac.webkit.org/changeset/214399>
WebKit Commit Bot
Comment 7 2017-03-25 07:44:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.