Bug 17006
| Summary: | [GTK] Header path should be webkit/webkit.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alp Toker <alp> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jmalonzo, mrowe |
| Priority: | P2 | Keywords: | Gtk |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Alp Toker
Right now, GTK+ API headers get installed into the top level include directory, eg. /usr/include/WebKitGtk/*.h
This means that developers do this in applications:
#include <webkit.h>
Our own webkit.h looks like this:
#ifndef __WEBKIT_H__
#define __WEBKIT_H__
#include <webkitdefines.h>
#include <webkitnetworkrequest.h>
#include <webkitwebframe.h>
#include <webkitwebsettings.h>
#include <webkitwebview.h>
#endif /* __WEBKIT_H__ */
I propose that we rename WebKit/gtk/WebView to WebKit/gtk/webkit to allow:
#include <webkit/webkit.h>
This matches GTK+ module conventions.
The alternative is to use ForwardingHeaders, which would help avoid the renaming in SVN, but the benefits of this aren't too clear for non-Apple APIs, and it would add maintenance overhead.
All in favour of renaming this directory and updating the necessary build systems and headers?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alp Toker
Fix landed in r29898.