Bug 17006 - [GTK] Header path should be webkit/webkit.h
Summary: [GTK] Header path should be webkit/webkit.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-01-25 07:17 PST by Alp Toker
Modified: 2008-01-31 16:31 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2008-01-25 07:17:31 PST 
Right now, GTK+ API headers get installed into the top level include directory, eg. /usr/include/WebKitGtk/*.h

This means that developers do this in applications:

#include <webkit.h>

Our own webkit.h looks like this:

#ifndef __WEBKIT_H__
#define __WEBKIT_H__

#include <webkitdefines.h>
#include <webkitnetworkrequest.h>
#include <webkitwebframe.h>
#include <webkitwebsettings.h>
#include <webkitwebview.h>

#endif /* __WEBKIT_H__ */


I propose that we rename WebKit/gtk/WebView to WebKit/gtk/webkit to allow:

#include <webkit/webkit.h>

This matches GTK+ module conventions.

The alternative is to use ForwardingHeaders, which would help avoid the renaming in SVN, but the benefits of this aren't too clear for non-Apple APIs, and it would add maintenance overhead.

All in favour of renaming this directory and updating the necessary build systems and headers?
Comment 1 Alp Toker 2008-01-31 16:31:29 PST 
Fix landed in r29898.