Bug 170056

Summary: [MediaStream] "ideal" constraints passed to getUserMedia should affect fitness score
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch. none

Eric Carlson
Reported 2017-03-24 09:48:27 PDT
"ideal" constraints passed to getUserMedia should affect fitness score
Attachments
Proposed patch. (35.46 KB, patch)
2017-03-24 12:22 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Proposed patch. (35.27 KB, patch)
2017-03-24 13:44 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-03-24 12:22:08 PDT
Created attachment 305313 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2017-03-24 12:23:01 PDT
<rdar://problem/31247451>
Eric Carlson
Comment 3 2017-03-24 13:44:41 PDT
Created attachment 305320 [details] Proposed patch.
youenn fablet
Comment 4 2017-03-24 15:28:54 PDT
Comment on attachment 305320 [details] Proposed patch. LGTM! Make sure to test LayoutTests/webrtc to check whether some tests break or not before landing.
Eric Carlson
Comment 5 2017-03-24 15:45:18 PDT
Comment on attachment 305320 [details] Proposed patch. This doesn't break any webrtc-specific tests.
WebKit Commit Bot
Comment 6 2017-03-24 16:27:18 PDT
Comment on attachment 305320 [details] Proposed patch. Clearing flags on attachment: 305320 Committed r214385: <http://trac.webkit.org/changeset/214385>
WebKit Commit Bot
Comment 7 2017-03-24 16:27:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.