Bug 170051

Summary:

[Modern Media Controls] Captions don't move with the appearance of the inline controls

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Antoine Quint 2017-03-24 06:31:42 PDT

We need to monitor when the controls bar fades in and out and offset the captions by the size of the controls bar.

Comment 1 Antoine Quint 2017-03-24 06:31:55 PDT

<rdar://problem/30754428>

Comment 2 Antoine Quint 2017-03-24 06:54:29 PDT

Created attachment 305280 [details]
Patch

Comment 3 Dean Jackson 2017-03-24 12:25:11 PDT

Comment on attachment 305280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305280&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));

I don't think you need the !! here.

Comment 4 Antoine Quint 2017-03-24 12:30:52 PDT

(In reply to Dean Jackson from comment #3)
> Comment on attachment 305280 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305280&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:221
> > +        this.host.textTrackContainer.classList.toggle("compact-controls-bar", !!(layoutTraits & LayoutTraits.Compact));
> 
> I don't think you need the !! here.

It's just so that we're passing a boolean in and not a number, which I think is cleaner.

Comment 5 WebKit Commit Bot 2017-03-24 15:10:49 PDT

Comment on attachment 305280 [details]
Patch

Clearing flags on attachment: 305280

Committed r214381: <http://trac.webkit.org/changeset/214381>

Comment 6 WebKit Commit Bot 2017-03-24 15:10:53 PDT

All reviewed patches have been landed.  Closing bug.