Bug 170023

Summary:

Web Inspector: Web Socket Document Icon

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, buildbot, commit-queue, hi, inspector-bugzilla-changes, joepeck, jond, mattbaker

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[IMAGE] Icons @1x	none
[PATCH] Proposed Fix (Purple)	none
[IMAGE] Icons @1x (Purple)	none
[PATCH] Proposed Fix	none
[IMAGE] Icons @1x (Purple)	none

Joseph Pecoraro

Reported 2017-03-23 13:48:22 PDT

Give Web Sockets a Document Image instead of the default empty document image. Images needed would be Web Socket variants of: DocumentGeneric.png DocumentGeneric@2x.png DocumentGenericLarge.png DocumentGenericLarge@2x.png

Attachments
[PATCH] Proposed Fix (9.51 KB, patch) 2017-03-28 11:11 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Icons @1x (170.53 KB, image/png) 2017-03-28 11:11 PDT, Joseph Pecoraro	no flags	Details
[PATCH] Proposed Fix (Purple) (8.68 KB, patch) 2017-03-28 14:32 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Icons @1x (Purple) (151.07 KB, image/png) 2017-03-28 14:33 PDT, Joseph Pecoraro	no flags	Details
[PATCH] Proposed Fix (8.37 KB, patch) 2017-05-18 14:11 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[IMAGE] Icons @1x (Purple) (198.18 KB, image/png) 2017-05-18 14:13 PDT, Joseph Pecoraro	no flags	Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Matt Baker

Comment 1 2017-03-23 14:24:03 PDT

A quick search for "Web Sockets logo" shows a plug-like icon that is fairly widespread. Maybe some variant on this?

Joseph Pecoraro

Comment 2 2017-03-28 11:11:02 PDT

Created attachment 305609 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2017-03-28 11:11:28 PDT

Created attachment 305610 [details] [IMAGE] Icons @1x

Matt Baker

Comment 4 2017-03-28 11:21:26 PDT

I like the up/down arrows, but think they should be thinner to be consistent with other icons.

Matt Baker

Comment 5 2017-03-28 11:22:07 PDT

We should also use a neutral color. Green implies something about the state of the socket (to me at least).

Devin Rousso

Comment 6 2017-03-28 11:53:15 PDT

This is kinda a NIT, but are we intentionally not having the little corner fold like for the HTML/CSS/JS/Document/Image icons?

Joseph Pecoraro

Comment 7 2017-03-28 11:55:29 PDT

(In reply to Devin Rousso from comment #6) > This is kinda a NIT, but are we intentionally not having the little corner > fold like for the HTML/CSS/JS/Document/Image icons? I noticed that but then came to like this change. Unlike other resources this is not a File resource. It is a Connection resource. The corner fold indicates this is a Text/File-like resource. No-fold indicates it is not, which I think makes sense for a Web Socket connection.

Matt Baker

Comment 8 2017-03-28 12:09:19 PDT

(In reply to Joseph Pecoraro from comment #7) > (In reply to Devin Rousso from comment #6) > > This is kinda a NIT, but are we intentionally not having the little corner > > fold like for the HTML/CSS/JS/Document/Image icons? > > I noticed that but then came to like this change. Unlike other resources > this is not a File resource. It is a Connection resource. The corner fold > indicates this is a Text/File-like resource. No-fold indicates it is not, > which I think makes sense for a Web Socket connection. Are there other resources that fall into this category? If so we should consider updating those icons too.

Joseph Pecoraro

Comment 9 2017-03-28 14:32:28 PDT

Created attachment 305643 [details] [PATCH] Proposed Fix (Purple)

Joseph Pecoraro

Comment 10 2017-03-28 14:33:05 PDT

Created attachment 305644 [details] [IMAGE] Icons @1x (Purple)

Joseph Pecoraro

Comment 11 2017-03-28 14:34:21 PDT

> Are there other resources that fall into this category? If so we should > consider updating those icons too. Not that I know of. This is the first of its kind. Workers were kind of close, but they are created with a single Script, so we have WorkerScript images which is like DocumentScript.png with extra flair.

Joseph Pecoraro

Comment 12 2017-03-28 14:36:09 PDT

Comment on attachment 305643 [details] [PATCH] Proposed Fix (Purple) Jon is making one with slightly thinner icons (for the small @1x).

Joseph Pecoraro

Comment 13 2017-05-18 14:11:22 PDT

Created attachment 310547 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 14 2017-05-18 14:13:12 PDT

Created attachment 310548 [details] [IMAGE] Icons @1x (Purple)

Matt Baker

Comment 15 2017-05-18 14:16:15 PDT

Comment on attachment 310547 [details] [PATCH] Proposed Fix r=me. I like the square corner.

WebKit Commit Bot

Comment 16 2017-05-18 14:44:39 PDT

Comment on attachment 310547 [details] [PATCH] Proposed Fix Clearing flags on attachment: 310547 Committed r217067: <http://trac.webkit.org/changeset/217067>

WebKit Commit Bot

Comment 17 2017-05-18 14:44:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.