Bug 170023

Summary: Web Inspector: Web Socket Document Icon
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, commit-queue, hi, inspector-bugzilla-changes, joepeck, jond, mattbaker
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Icons @1x
none
[PATCH] Proposed Fix (Purple)
none
[IMAGE] Icons @1x (Purple)
none
[PATCH] Proposed Fix
none
[IMAGE] Icons @1x (Purple) none

Description Joseph Pecoraro 2017-03-23 13:48:22 PDT
Give Web Sockets a Document Image instead of the default empty document image.

Images needed would be Web Socket variants of:

    DocumentGeneric.png
    DocumentGeneric@2x.png
    DocumentGenericLarge.png
    DocumentGenericLarge@2x.png
Comment 1 Matt Baker 2017-03-23 14:24:03 PDT
A quick search for "Web Sockets logo" shows a plug-like icon that is fairly widespread. Maybe some variant on this?
Comment 2 Joseph Pecoraro 2017-03-28 11:11:02 PDT
Created attachment 305609 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-03-28 11:11:28 PDT
Created attachment 305610 [details]
[IMAGE] Icons @1x
Comment 4 Matt Baker 2017-03-28 11:21:26 PDT
I like the up/down arrows, but think they should be thinner to be consistent with other icons.
Comment 5 Matt Baker 2017-03-28 11:22:07 PDT
We should also use a neutral color. Green implies something about the state of the socket (to me at least).
Comment 6 Devin Rousso 2017-03-28 11:53:15 PDT
This is kinda a NIT, but are we intentionally not having the little corner fold like for the HTML/CSS/JS/Document/Image icons?
Comment 7 Joseph Pecoraro 2017-03-28 11:55:29 PDT
(In reply to Devin Rousso from comment #6)
> This is kinda a NIT, but are we intentionally not having the little corner
> fold like for the HTML/CSS/JS/Document/Image icons?

I noticed that but then came to like this change. Unlike other resources this is not a File resource. It is a Connection resource. The corner fold indicates this is a Text/File-like resource. No-fold indicates it is not, which I think makes sense for a Web Socket connection.
Comment 8 Matt Baker 2017-03-28 12:09:19 PDT
(In reply to Joseph Pecoraro from comment #7)
> (In reply to Devin Rousso from comment #6)
> > This is kinda a NIT, but are we intentionally not having the little corner
> > fold like for the HTML/CSS/JS/Document/Image icons?
> 
> I noticed that but then came to like this change. Unlike other resources
> this is not a File resource. It is a Connection resource. The corner fold
> indicates this is a Text/File-like resource. No-fold indicates it is not,
> which I think makes sense for a Web Socket connection.

Are there other resources that fall into this category? If so we should consider updating those icons too.
Comment 9 Joseph Pecoraro 2017-03-28 14:32:28 PDT
Created attachment 305643 [details]
[PATCH] Proposed Fix (Purple)
Comment 10 Joseph Pecoraro 2017-03-28 14:33:05 PDT
Created attachment 305644 [details]
[IMAGE] Icons @1x (Purple)
Comment 11 Joseph Pecoraro 2017-03-28 14:34:21 PDT
> Are there other resources that fall into this category? If so we should
> consider updating those icons too.

Not that I know of. This is the first of its kind.

Workers were kind of close, but they are created with a single Script, so we have WorkerScript images which is like DocumentScript.png with extra flair.
Comment 12 Joseph Pecoraro 2017-03-28 14:36:09 PDT
Comment on attachment 305643 [details]
[PATCH] Proposed Fix (Purple)

Jon is making one with slightly thinner icons (for the small @1x).
Comment 13 Joseph Pecoraro 2017-05-18 14:11:22 PDT
Created attachment 310547 [details]
[PATCH] Proposed Fix
Comment 14 Joseph Pecoraro 2017-05-18 14:13:12 PDT
Created attachment 310548 [details]
[IMAGE] Icons @1x (Purple)
Comment 15 Matt Baker 2017-05-18 14:16:15 PDT
Comment on attachment 310547 [details]
[PATCH] Proposed Fix

r=me. I like the square corner.
Comment 16 WebKit Commit Bot 2017-05-18 14:44:39 PDT
Comment on attachment 310547 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 310547

Committed r217067: <http://trac.webkit.org/changeset/217067>
Comment 17 WebKit Commit Bot 2017-05-18 14:44:40 PDT
All reviewed patches have been landed.  Closing bug.