Bug 169987

Summary:

NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

169245

Attachments:

Description	Flags
Patch	achristensen: review+

Description Dean Jackson 2017-03-22 18:52:24 PDT

CSSDefaultStyleSheets creates a static MediaQueryEvaluator, but thanks to the template magic of NeverDestroyed, it was converting the char* argument into a bool, and calling the wrong constructor.

Comment 1 Dean Jackson 2017-03-22 18:53:04 PDT

<rdar://problem/31211087>

Comment 2 Dean Jackson 2017-03-22 18:57:04 PDT

Created attachment 305152 [details]
Patch

Comment 3 Dean Jackson 2017-03-23 11:19:12 PDT

Committed r214305: <http://trac.webkit.org/changeset/214305>