Bug 169961

Summary: [QuickLook] Rename QuickLookHandle to PreviewLoader
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dbates, japhet, kling, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170342    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2017-03-22 10:12:40 PDT
[QuickLook] Rename QuickLookHandle to PreviewLoader
Attachments
Patch (91.35 KB, patch)
2017-03-22 10:16 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-03-22 10:16:36 PDT
Created attachment 305104 [details] Patch
Build Bot
Comment 2 2017-03-22 10:19:40 PDT
Attachment 305104 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ios/PreviewLoader.mm:187: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/loader/ios/PreviewLoader.mm:211: Extra space in capture list. [whitespace/brackets] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:49: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2017-03-22 11:11:12 PDT
Comment on attachment 305104 [details] Patch Clearing flags on attachment: 305104 Committed r214266: <http://trac.webkit.org/changeset/214266>
WebKit Commit Bot
Comment 4 2017-03-22 11:11:16 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2017-03-22 13:49:26 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 305104 [details] > Patch > > Clearing flags on attachment: 305104 > > Committed r214266: <http://trac.webkit.org/changeset/214266> It broke the Apple Mac cmake build: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/113
Note You need to log in before you can comment on or make changes to this bug.