Bug 169961 - [QuickLook] Rename QuickLookHandle to PreviewLoader
Summary: [QuickLook] Rename QuickLookHandle to PreviewLoader
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
Depends on: 170342
  Show dependency treegraph
Reported: 2017-03-22 10:12 PDT by Andy Estes
Modified: 2017-03-31 08:53 PDT (History)
8 users (show)

See Also:

Patch (91.35 KB, patch)
2017-03-22 10:16 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-03-22 10:12:40 PDT
[QuickLook] Rename QuickLookHandle to PreviewLoader
Comment 1 Andy Estes 2017-03-22 10:16:36 PDT
Created attachment 305104 [details]
Comment 2 Build Bot 2017-03-22 10:19:40 PDT
Attachment 305104 [details] did not pass style-queue:

ERROR: Source/WebCore/loader/ios/PreviewLoader.mm:187:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/loader/ios/PreviewLoader.mm:211:  Extra space in capture list.  [whitespace/brackets] [4]
ERROR: Source/WebKit2/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:49:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 25 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-03-22 11:11:12 PDT
Comment on attachment 305104 [details]

Clearing flags on attachment: 305104

Committed r214266: <http://trac.webkit.org/changeset/214266>
Comment 4 WebKit Commit Bot 2017-03-22 11:11:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2017-03-22 13:49:26 PDT
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 305104 [details]
> Patch
> Clearing flags on attachment: 305104
> Committed r214266: <http://trac.webkit.org/changeset/214266>

It broke the Apple Mac cmake build: