Bug 169899

Summary:

REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2017-03-20 17:06:57 PDT

This was implemented a long time ago but broke when we transitioned to ES6 classes: Bug 147439 - Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes.

Unfortunately, JavaScript doesn't show any warnings for `aNumber - undefined`.

Comment 1 Radar WebKit Bug Importer 2017-03-20 17:07:34 PDT

<rdar://problem/31160842>

Comment 2 Nikita Vasilyev 2017-03-20 17:08:39 PDT

Created attachment 304969 [details]
Patch

Comment 3 Joseph Pecoraro 2017-03-20 17:16:44 PDT

Comment on attachment 304969 [details]
Patch

rs=me

Comment 4 WebKit Commit Bot 2017-03-20 17:46:14 PDT

Comment on attachment 304969 [details]
Patch

Clearing flags on attachment: 304969

Committed r214198: <http://trac.webkit.org/changeset/214198>

Comment 5 WebKit Commit Bot 2017-03-20 17:46:20 PDT

All reviewed patches have been landed.  Closing bug.