Bug 169888

Summary:

Charts page show an inconsistent list of revisions for Git and Subversion

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	commit-queue: commit-queue-

Ryosuke Niwa

Reported 2017-03-20 13:54:15 PDT

When using Git, we end up showing the last data point's revision instead of all revisions after the last data point.

Attachments
Patch (123.55 KB, patch) 2017-03-20 15:44 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (90.08 KB, patch) 2017-03-20 17:11 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (90.41 KB, patch) 2017-03-20 17:20 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch for landing (90.41 KB, patch) 2017-03-20 17:25 PDT, Ryosuke Niwa	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-03-20 15:44:23 PDT

Created attachment 304960 [details] Patch

Ryosuke Niwa

Comment 2 2017-03-20 17:11:08 PDT

Created attachment 304970 [details] Patch for landing

WebKit Commit Bot

Comment 3 2017-03-20 17:12:40 PDT

Comment on attachment 304970 [details] Patch for landing Rejecting attachment 304970 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 304970, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Websites/perf.webkit.org/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/3372326

Ryosuke Niwa

Comment 4 2017-03-20 17:20:16 PDT

Created attachment 304973 [details] Patch for landing

WebKit Commit Bot

Comment 5 2017-03-20 17:21:38 PDT

Comment on attachment 304973 [details] Patch for landing Rejecting attachment 304973 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 304973, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /perf.webkit.org/public/v3/models/data-model.js patching file Websites/perf.webkit.org/public/v3/remote.js patching file Websites/perf.webkit.org/server-tests/api-commits-tests.js patching file Websites/perf.webkit.org/server-tests/api-commits.js rm 'Websites/perf.webkit.org/server-tests/api-commits.js' patching file Websites/perf.webkit.org/unit-tests/commit-log-tests.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3372444

Ryosuke Niwa

Comment 6 2017-03-20 17:25:52 PDT

Created attachment 304976 [details] Patch for landing

WebKit Commit Bot

Comment 7 2017-03-20 17:28:10 PDT

Comment on attachment 304976 [details] Patch for landing Rejecting attachment 304976 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 304976, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /perf.webkit.org/public/v3/models/data-model.js patching file Websites/perf.webkit.org/public/v3/remote.js patching file Websites/perf.webkit.org/server-tests/api-commits-tests.js patching file Websites/perf.webkit.org/server-tests/api-commits.js rm 'Websites/perf.webkit.org/server-tests/api-commits.js' patching file Websites/perf.webkit.org/unit-tests/commit-log-tests.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3372483

Ryosuke Niwa

Comment 8 2017-03-20 18:19:47 PDT

Committed r214202: <http://trac.webkit.org/changeset/214202>

Note You need to log in before you can comment on or make changes to this bug.