Bug 169867

Summary: B3::LowerToAir incorrectly selects BitXor(AtomicStrongCAS(...), $1)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-03-19 16:14:58 PDT
It thinks that this is just like NotEqual(AtomicStrongCAS(@exp, ...), @exp). It's not. We need to teach it to only look for AtomicWeakCAS in that pattern, not any AtomicCAS.
Attachments
the patch (4.29 KB, patch)
2017-04-04 15:06 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-04-04 15:06:37 PDT
Created attachment 306210 [details] the patch
Filip Pizlo
Comment 2 2017-04-04 15:38:14 PDT
Landed in https://trac.webkit.org/changeset/214908/webkit
Note You need to log in before you can comment on or make changes to this bug.